Time picker throws warnings for single-digit times in Chrome

Description

When you try to create a talk using Chrome, the time-picker doens't update the input field if the hour is single digit (e.g. 9:00, 8:30 etc).

The console throws the following warning:

""The specified value "9:15" does not conform to the required format. The format is "HH:mm", "HH:mm:ss" or "HH:mm:ss.SSS" where HH is 00-23, mm is 00-59, ss is 00-59, and SSS is 000-999.""

If the hour is a double digit hour (10, 11 etc), it works fine.

Works even with a single digit hour in Firefox

Activity

Show:

Mark RailtonOctober 2, 2016 at 10:45 AM

Changes merged

Mark RailtonOctober 2, 2016 at 8:50 AM

Never seen your comment Liam, have merged it already, I just can't close jira issues yet

LiamOctober 2, 2016 at 6:08 AM

Thanks, will merge that today.

Yes exactly, open a JIRA issue with a link know to the PR so we can look to update the component once the upstream is.

Calum BulmerOctober 2, 2016 at 12:26 AM

Ok,

I have fixed the component and submitted a PR

Not sure quite what you mean regards to b)... Do you mean crate a new jira issue to re-pull the bootstrap-timepicker.js component once the PR on that component has been merged / the component has been fixed??

LiamSeptember 30, 2016 at 8:37 PM
Edited

Not sure on anyone else's preference, but I don't really want to remove the component, as apart from the bug it does work well.

As such, personally, I'd:

a) Fix the component for now
b) Raise a ticket in reference to the PR on the upstream project, to re-pull in that component once it's available.

That way, we get the best of both worlds

Fixed

Details

Assignee

Reporter

Labels

Components

Priority

Created September 5, 2016 at 2:24 PM
Updated October 2, 2016 at 10:45 AM
Resolved October 2, 2016 at 10:45 AM