Uploaded image for project: 'joind.in'
  1. JOINDIN-733

Return type of Request::getParameter() method should be mixed

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Trivial
    • Resolution: Unresolved
    • Component/s: API (v2)
    • Labels:
    • Sprint:

      Description

      Currently, the docblock for Request::getParameter() suggest the return will be a string: https://github.com/joindin/joindin-api/blob/master/src/inc/Request.php#L191states

      However, as the paramter property can be the result of a JSON body (and they are not cast anywhere), then a value could be string, int, bool, and (I think) stdClass.

      Suggest the docblock is updated to reflect this.

        Attachments

          Activity

            People

            • Assignee:
              info Giorgio Sironi
              Reporter:
              liam-wiltshire Liam
            • Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: